Skip to content

Conversation

@petak5
Copy link
Member

@petak5 petak5 commented May 21, 2020

Routes for basic CRUD for most models is implemented, data validation will need to be done in another branch once the login/sessions system is complete.

petak5 and others added 30 commits April 12, 2020 10:56
# Conflicts:
#	Pipfile.lock
#	src/api/views/__init__.py
	modified:   src/api/models/__init__.py
This was linked to issues Jun 14, 2020
@petak5 petak5 requested a review from cgeopapa June 14, 2020 21:17
@ghost
Copy link

ghost commented Jun 15, 2020

Pipfile.lock needs updating and 16 tests pass 5 fail
We talked about this beforehand so the merge can go ahead right now and we will fix these errors in a separate PR
Good job @petak5 and @marter11

ghost
ghost previously approved these changes Jun 15, 2020
@petak5 petak5 dismissed ghost ’s stale review via 0886a83 June 15, 2020 06:19
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the missing atomicwrites issue on windows. thanks

@petak5 petak5 merged commit 879c643 into develop Jun 15, 2020
@petak5 petak5 deleted the routes branch June 15, 2020 06:24
@petak5 petak5 linked an issue Jun 15, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up testing Write documentation Write tests

4 participants